search

netresearch / mediawiki-libravatar

Provides a <libravatar email="foo@example.org"/> tag for MediaWiki which displays the avatar image for a given email address, using the Libravatar service.
GNU Affero General Public License v3.0
1 stars 1 forks source link

Add support for requesting HTTPS to fetch avatars #2

Closed strk closed 6 years ago

strk commented 6 years ago

it would help to be able to request HTTPS, either globally (default) or a per-tag

strk commented 6 years ago

Libravatar.php documentation says:

Instead of manually deciding if you need HTTPS or not, Services_Libravatar will detect that automatically when calling detectHttps().

strk commented 6 years ago

It looks like the code already calls detectHttps, so I dunno why someone reported an http url was being hit instead: https://trac.osgeo.org/osgeo/ticket/1688#comment:7

For the tag-local approach there could also be this: http://pear.php.net/package/Services_Libravatar/docs/latest/Services_Libravatar/Services_Libravatar.html#methodsetHttps

strk commented 6 years ago

@cweiske any idea about this ? Could it be that the http (non 'secure') was returned as a redirect by libravatar.org when asked an https to it ?

strk commented 6 years ago

@cweiske it looks like <Libravatar>EMAIL</Libravatar> vs. <Libravatar email="EMAIL" /> seems to make a difference, does it sound ?