search

neuralyzer / dokuwiki-plugin-revealjs

Reval.js plugin for dokuwiki
16 stars 12 forks source link

All options overwritable per wiki page #12

Closed ogobrecht closed 8 years ago

ogobrecht commented 8 years ago

Hi,

regarding issue #8 - this is a general solution for all current and possible future options.

Please have a look and let me know, if I should change something or if you don't like this at all.

Best regards Ottmar

Changes overview

syntax/theme.php

Parse options as query string

Allow the old syntax for only the theme name or the the new syntax for more options as a query string like 

~~REVEAL theme=sky&transition=convex&controls=1~~

Put all options except open_in_new_window to the export URL

renderer.php

Merge URL params into plugin conf

Changing parameters direct in the URL is only working, when the page is not cached (~~NOCACHE~~).

The good thing with ~~NOCACHE~~ is, that you are able to change the layout on the fly by only changing the URL. If you encounter any problems during a presentation e.g. bad contrast, then you are able to change this without editing the wiki page.

example_presentation.dokuwiki

Example parameters, new List page and cleanup

README.md

Add description for the new functionality

neuralyzer commented 8 years ago

Hi,

I like your idea to overwrite config options. Just one minor thing: I would like to put quotes around the array keys in line 59 and 61 in the new renderer.php. And maybe also remove the call to dbg in listitem_open ?

Cheers

ogobrecht commented 8 years ago

Hi,

sorry for the forgotten dbg call :-(

Sure, you can change what you want, it is your code :-)

I will checkout your changes then to my fork. What do you think about the slide_level and push_headers from my yesterday opened issue? Should I create a pull request for that?

Best regards Ottmar

Am 15.09.2016 um 09:40 schrieb neuralyzer notifications@github.com:

Hi,

I like your idea to overwrite config options. Just one minor thing: I would like to put quotes around the array keys in line 59 and 61 in the new renderer.php. And maybe also remove the call to dbg in listitem_open ?

Cheers

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.