[ENH] Switch node config format - Githubissues

neurobagel / federation-api

REST API for query federation over multiple Neurobagel graph databases

https://federate.neurobagel.org

MIT License

0 stars 0 forks source link

[ENH] Switch node config format #39

Closed alyssadai closed 11 months ago

alyssadai commented 12 months ago

Closes #32
Closes #35

Changes proposed in this pull request:

User-defined local nodes are now read from a specifically named JSON file (local_nb_nodes.json) instead of an .env file
Logic added to:
- Raise warning + use remote public nodes only when local_nb_nodes.json doesn't exist or is empty
- Raise error (and exit app) when there are no locally defined nodes AND the request to the public node index fails
README updated with instructions for exposing new JSON file to a Docker container

Checklist

[x] PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) _(see https://neurobagel.org/contributing/pull_requests for more info)_
[x] PR links to GitHub issue with mention Closes #XXXX
[x] Tests pass
[x] Checks pass

For new features:

[ ] Tests have been added

For bug fixes:

[ ] There is at least one test that would fail under the original bug conditions.

coveralls commented 12 months ago

Pull Request Test Coverage Report for Build 7089889025

79 of 79 (100.0%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.4%) to 98.322%

Totals
Change from base Build 7037895045:	0.4%
Covered Lines:	293
Relevant Lines:	298

💛 - Coveralls

surchs commented 7 months ago

:rocket: PR was released in v0.1.0 :rocket: