[FIX] Handle empty local nodes file - Githubissues

neurobagel / federation-api

REST API for query federation over multiple Neurobagel graph databases

https://federate.neurobagel.org

MIT License

0 stars 0 forks source link

[FIX] Handle empty local nodes file #67

Closed alyssadai closed 9 months ago

alyssadai commented 9 months ago

Closes #66

Changes proposed in this pull request:

Empty local_nb_nodes.json file now handled gracefully without erroring
Added new test case for above
Moved test case for local nodes file with empty dict {} to more appropriate test (as it currently raises a warning)

Checklist

[x] PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) _(see https://neurobagel.org/contributing/pull_requests for more info)_
[x] PR has a label for the release changelog or skip-release (to be applied by maintainers only)
[x] PR links to GitHub issue with mention Closes #XXXX
[x] Tests pass
[x] Checks pass

For new features:

[x] Tests have been added

For bug fixes:

[ ] There is at least one test that would fail under the original bug conditions.

coveralls commented 9 months ago

Pull Request Test Coverage Report for Build 7729709162

0 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.005%) to 99.322%

Totals
Change from base Build 7722223666:	0.005%
Covered Lines:	586
Relevant Lines:	590

💛 - Coveralls

surchs commented 7 months ago

:rocket: PR was released in v0.1.0 :rocket: