neurobagel / federation-api

REST API for query federation over multiple Neurobagel graph databases
https://federate.neurobagel.org
MIT License
0 stars 0 forks source link

[ENH] Implemented `NB_FEDERATE_REMOTE_PUBLIC_NODES` env var #90

Closed rmanaem closed 6 months ago

rmanaem commented 6 months ago

Checklist

This section is for the PR reviewer

For new features:

For bug fixes:

coveralls commented 6 months ago

Pull Request Test Coverage Report for Build 9274359452

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
tests/test_utility.py 12 13 92.31%
<!-- Total: 28 29 96.55% -->
Totals Coverage Status
Change from base Build 9224646794: -0.08%
Covered Lines: 471
Relevant Lines: 486

💛 - Coveralls
rmanaem commented 6 months ago

provide basic docs for this new feature. if README isn't the place, then please make a PR against the ENV var table in the main docs and link here

Addressing that here https://github.com/neurobagel/recipes/issues/60

add a basic integration test to make sure the ENV var does what we think it does

Test has been added

surchs commented 5 months ago

:rocket: PR was released in v0.2.0 :rocket: