[FIX] Explicitly check that `local_nb_nodes.json` is an existing file - Githubissues

neurobagel / federation-api

REST API for query federation over multiple Neurobagel graph databases

https://federate.neurobagel.org

MIT License

0 stars 0 forks source link

[FIX] Explicitly check that `local_nb_nodes.json` is an existing file #98

Closed alyssadai closed 5 months ago

alyssadai commented 5 months ago

Closes #81

Changes proposed in this pull request:

Instead of simply checking if the path exists (which can cause problems if the path points to a directory instead of a file), check if local_nb_nodes.json is an existing file

Checklist

This section is for the PR reviewer

[x] PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
[x] PR has a label for the release changelog or skip-release (to be applied by maintainers only)
[x] PR links to GitHub issue with mention Closes #XXXX
[x] Tests pass
[x] Checks pass

For new features:

[x] Tests have been added

For bug fixes:

[ ] There is at least one test that would fail under the original bug conditions.

surchs commented 5 months ago

:rocket: PR was released in v0.2.1 :rocket: