maxx1128
commented
7 years ago Looks and works great! Understandable that you had other priorities before getting to it. The only issue I see is the mobile menu isn't opening for some reason. There was a jQuery-related error in the console that's likely connected, is below.
TypeError: a.getAttribute is not a functionOnce that's set and the mobile menu is fixed then it'll be good to merge. As for the paginator and general layout, I can add some flexbox later on so it handles better on mobile and other screen sizes.
kljensen
sukima
treznick
Oh boy this was a doozy. Sorry it took so long but work and family kept getting in the way.
Coming from Ember.JS (and this is probubly true for Angular devs too) the push to components for rendering part of a page is quite prominent. Much of Ember is trying to close the gap between the web components standard and the do-it-yourself frameworks.
Using those ideals it seemed appropriate to look into the web component standard. The concepts were perfect for the problem domain on the website. So I dove in. I wanted to have a safety net so I also worked on developing a test suite.
After it was all done I also looked into a way to search for developers. Sadly though the Meetup API does not support text searching members.
Another edge case I found was that the paginator (even the original one) doesn't scale well when you get enough members to cause the list to wrap to the next line. Perhaps a new paginator design would help or maybe some fancy flexbox work. If anyone has thoughts on this perhaps we can discuss it here.