search

newhavenio / newhavenio.github.io

active version of the website for newhaven.io built on the Jekyll framework
http://newhavenio.github.io/
MIT License
13 stars 12 forks source link

Removes minimize: true from CSS loader webpack config #120

Closed mzemel closed 4 years ago

mzemel commented 4 years ago

Looks like this might solve it?

https://github.com/webpack-contrib/css-loader/issues/863

I haven't tried replicating locally so let's see what CI says.

fergyfresh commented 4 years ago

LOL I just did this here https://github.com/newhavenio/newhavenio.github.io/pull/119. I'll close mine.

fergyfresh commented 4 years ago

It brought up more errors. https://travis-ci.org/newhavenio/newhavenio.github.io/builds/557402482?utm_source=github_status&utm_medium=notification

mzemel commented 4 years ago

@fergyfresh Bummer.

I can't justify doing a webpack troubleshooting sesh, so I'm going to close this PR as well.

fergyfresh commented 4 years ago

Yeah. That's when I gave up as well. This is why I hate JavaScript.

bmack123 commented 4 years ago

So I think that we could have solved this by doing $icon-font-path: ~bootstrap-sass/assets/fonts/bootstrap (they changed the asset path and it couldn't find them), but I also upgraded us to webpack 4 because officiall css-loader v3 doesn't support webpack v3. https://github.com/newhavenio/newhavenio.github.io/pull/121