newhavenio / newhavenio.github.io

active version of the website for newhaven.io built on the Jekyll framework
http://newhavenio.github.io/
MIT License
13 stars 12 forks source link

Fix tests in chrome and safari #13

Closed sukima closed 7 years ago

sukima commented 7 years ago

Sigh, This is getting ridiculous. The problems seem to be that the folks who wrote the webcomponents polyfill either neglected to mention browser differences or the browsers are being stupid at following specs.

So the fix that worked for Firefox cause chrome to execute mocha.run before the test cases were loaded. (╯°□°)╯︵┻━┻

Also, Safari returns length as an enumerable when Chrome and Firefox do not. Again I got bit by using Vanilla JS and only MDN.

Changing the order fixes it. I swear I've now tested this in

Really sorry for the multiple pull requests.