search

newhavenio / newhavenio.github.io

active version of the website for newhaven.io built on the Jekyll framework
http://newhavenio.github.io/
MIT License
13 stars 12 forks source link

Add some loading state behavior to slackin button #56

Closed treznick closed 6 years ago

sukima commented 6 years ago

There is loading state. It shows an animated GIF while it is waiting for Heroku to spin up. Did something break?

treznick commented 6 years ago

8bd493d235cdea4f9dfe299079f8dfd3424ad5ea removed the webcomponent, 002e0a7b348ce2a36b2c144515702a38e53e3629 removed the onload.

I think just having the <script> in the div is fine enough with an onload. Probably no need to have the webcomponent. I'm also happy to entertain more conversation. cc @NerdsvilleCEO

sukima commented 6 years ago

Can't help then. The reason for a webcomponent was so it should handle a loading state while the heroku app spun up. It was the premise of https://github.com/newhavenio/newhavenio.github.io/pull/27 I didn't know we reverted that PR.

thatnerdjosh commented 6 years ago

@sukima I wrote some code which changes it to not be a webcomponent and resizes the icon, (I don't know how webcomponents work) we should merge the efforts I made to resize the icon with your knowledge of webcomponents @treznick also I prefer webcomponent it seems cleaner, I just don't understand the state too much and was fighting with it more than anything, I will coordinate to figure out where we are at on that

thatnerdjosh commented 6 years ago

oh crap I feel bad, I didn't realize that PR got merged... was trying to find that and just noticed... I will PM you @sukima and we can work to get the changes into a webcomponent, was running into issues w/ the script as a webcomponent

treznick commented 6 years ago

@NerdsvilleCEO no worries! I merged and then realized the changes. My bad. @sukima @NerdsvilleCEO I’ll PR a revert and then can you both look into getting the web component to respect the large parameter?

sukima commented 6 years ago

@NerdsvilleCEO you on the Slacks? You available tomorrow some time. Would be happy to pair during a lunch break.

thatnerdjosh commented 6 years ago

I think we can close this... @sukima I want to work with you on the PR #58, in the one that was reverted I had the button centered with also a drop down on page so they don't need to navigate away