search

newhavenio / newhavenio.github.io

active version of the website for newhaven.io built on the Jekyll framework
http://newhavenio.github.io/
MIT License
13 stars 12 forks source link

We have both package-lock.json and yarn.lock #75

Closed jnimety closed 6 years ago

jnimety commented 6 years ago

We need to settle on one package management solution. @NerdsvilleCEO did you intend to commit package-lock.json?

bsutt123 commented 6 years ago

with npm version 6 coming out with a more security featured mindset, we might want to switch to npm, but I vote yarn and we remove the package-lock.json. But I am willing to be wrong if others feel strongly about npm versus yarn.

sukima commented 6 years ago

The difference is mainly aesthetics. They almost have feature parity at this point.

From what I know, NPM is needed when working with global modules (not applicable here) or with the NPM registry (like publishing, again not applicable here). Yarn on the other hand seems a little more friendly as a UI and a git friendly lock file. But really that doesn't mean much and is more opinion then fact.

In the long run it really is 6 in one hand and a half-dozen in another. Yarn is not going away soon and I'm willing to bet that when it does this site will be on some new fangled system beyond JS when the community pendulum swings back around again. Not to mention switching is a single commit easily accomplished.

Just to play devil's advocate, You can have both in a project. Though it does mean keeping the two in sync requires two commands and a lot of wasted disk I/O.

treznick commented 6 years ago

I mean, we can have two, but I'd say we should only use one. Fine to use whichever.

On Mon, Apr 30, 2018 at 11:52 AM Devin Weaver notifications@github.com wrote:

The difference is mainly aesthetics. They almost have feature parity at this point.

From what I know, NPM is needed when working with global modules (not applicable here) or with the NPM registry (like publishing, again not applicable here). Yarn on the other hand seems a little more friendly as a UI and a git friendly lock file. But really that doesn't mean much and is more opinion then fact.

In the long run it really is 6 in one hand and a half-dozen in another. Yarn is not going away soon and I'm willing to bet that when it does this site will be on some new fangled system beyond JS when the community pendulum swings back around again. Not to mention switching is a single commit easily accomplished.

Just to play devil's advocate, You can have both in a project. Though it does mean keeping the two in sync requires two commands and a lot of wasted disk I/O.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/newhavenio/newhavenio.github.io/issues/75#issuecomment-385441847, or mute the thread https://github.com/notifications/unsubscribe-auth/AAlwA__1XF8bykz8nTeIq4DxUH1KaIUBks5ttzNYgaJpZM4Trbam .

thatnerdjosh commented 6 years ago

I would vote to use npm, and I think we should only have one in there to encourage usage thereof because I've seen issues on personal projects using both. I think whichever we decide to use we should remove the other

jnimety commented 6 years ago

we shouldn't have two, they resolve dependencies differently and the whole point is to have deterministic dependencies and versions across dev and production environments.

On Mon, Apr 30, 2018 at 11:12 AM Joshua Santos notifications@github.com wrote:

I would vote to use npm, and I think we should only have one in there to encourage usage thereof because I've seen issues on personal projects using both. I think whichever we decide to use we should remove the other

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/newhavenio/newhavenio.github.io/issues/75#issuecomment-385447765, or mute the thread https://github.com/notifications/unsubscribe-auth/AAETVL6Gby-UzZMf13c7bC3-qX6bz6Spks5ttzfogaJpZM4Trbam .

treznick commented 6 years ago

I prefer yarn because it got around to deterministic installs before npm, but I'm happy to use either

On Mon, Apr 30, 2018 at 12:58 PM Joel Nimety notifications@github.com wrote:

we shouldn't have two, they resolve dependencies differently and the whole point is to have deterministic dependencies and versions across dev and production environments.

On Mon, Apr 30, 2018 at 11:12 AM Joshua Santos notifications@github.com wrote:

I would vote to use npm, and I think we should only have one in there to encourage usage thereof because I've seen issues on personal projects using both. I think whichever we decide to use we should remove the other

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/newhavenio/newhavenio.github.io/issues/75#issuecomment-385447765 , or mute the thread < https://github.com/notifications/unsubscribe-auth/AAETVL6Gby-UzZMf13c7bC3-qX6bz6Spks5ttzfogaJpZM4Trbam

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/newhavenio/newhavenio.github.io/issues/75#issuecomment-385460988, or mute the thread https://github.com/notifications/unsubscribe-auth/AAlwAytnkyeTqVJAyE8GYtqtNTwtwuOFks5tt0LAgaJpZM4Trbam .

sukima commented 6 years ago

This was discussed previously and chosen to use yarn: https://github.com/newhavenio/newhavenio.github.io/pull/33#issuecomment-354467390

treznick commented 6 years ago

then let's let the caprice of the random number generator drive the course of our souls!

kidding. yarn it is :)

On Mon, Apr 30, 2018 at 3:18 PM Devin Weaver notifications@github.com wrote:

This was discussed previously and chosen to use yarn: #33 (comment) https://github.com/newhavenio/newhavenio.github.io/pull/33#issuecomment-354467390

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/newhavenio/newhavenio.github.io/issues/75#issuecomment-385500747, or mute the thread https://github.com/notifications/unsubscribe-auth/AAlwA49mwcaThYAq228PbFpxgnAz93Iqks5tt2N2gaJpZM4Trbam .