search

newhavenio / newhavenio.github.io

active version of the website for newhaven.io built on the Jekyll framework
http://newhavenio.github.io/
MIT License
13 stars 12 forks source link

Feature/bundle css with webpack #84

Closed bsutt123 closed 6 years ago

bsutt123 commented 6 years ago

Extracts the SASS from the jekyll building and moves it to webpack build tools, allowing us to again not have to include the assets manually.

treznick commented 6 years ago

@bsutt123 regarding 368838c08cce27986b7391702f993a7464337072

is main.css something that should be under version control? won't it just get built in the deploy process?

bsutt123 commented 6 years ago

@treznick Probably not. I think that it and bundle.js can be removed from dependencies. Originally you had to build the bundle so it was included when you pushed to master branch, but then we implemented Travis which means we don't need either.

I'll remove both and push next time I'm at my Desktop.

bsutt123 commented 6 years ago

Merged in, but apparently Travis isn't building the main.css or bundle.js like we thought, so once those weren't included in version control it broke. I'm going to do a little research and come back to this.