nextcloud / files_antivirus

👾 Antivirus app for Nextcloud Files
https://apps.nextcloud.com/apps/files_antivirus
GNU Affero General Public License v3.0
84 stars 35 forks source link

In the backgroundjob rescan old files #145

Closed rullzer closed 4 years ago

rullzer commented 4 years ago

The virus/malware definitions might have been updated. So it makes sense to just keep scanning the files.

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

icewind1991 commented 4 years ago

I feel that this would create serious scalability issues, once enough files are stored that scanning them all takes >1d the scanner will just be running 100% non stop.

An alternative option might be to re-scan files on download if the last scan is old, it would add some latency to the download but doesn't cause a constant load

rullzer commented 4 years ago

I mean we can also make it a week or a month. The time was just chosen randomly

rullzer commented 4 years ago

@icewind1991 now it just keeps scanning every 28 days. Which it should I think so that if you have new virus definitions things still get rescanned etc.