nextcloud / photos

📸 Your memories under your control
GNU Affero General Public License v3.0
579 stars 61 forks source link

Merging recognized faces of different people is cumbersome and error prone #1505

Open csware opened 1 year ago

csware commented 1 year ago

Describe the bug Install the face recognition (great idea to add such a detection!) When trying to merge detected persons, the list is constanly updating and it is highly likely that the order changes and ylou click on the 'wrong' person.

Also, when you open a person, highlight the spotted face in the photos so that it is easier to see whether the correct face was recognized (this would be particularly helpful is several people are on the photo).

Also, quite often a JavaScript error occurs:

TypeError: n.faceDetections.find(...) is undefined
    getFaceCover FaceCoverMixin.js:53
    getFaceCover FaceCoverMixin.js:52
    getCoverStyle FaceCoverMixin.js:76
    H FaceMergeForm.vue:1
    tt VueJS
    H FaceMergeForm.vue:1
    VueJS 62
    click FaceContent.vue:1
    VueJS 4
    onClick ncvuecomponents.js:2
    VueJS 3

To Reproduce Steps to reproduce the behavior:

  1. Go to /apps/photos/faces/
  2. Select a person
  3. Open the menu and select 'merge'

Expected behavior The list is static, ordered by the number of associated fotos, and the images are loaded on an best-.effort basis.

Desktop (please complete the following information):

bpmartin20 commented 1 year ago

I agree with the first paragraph particularly. This may be related to the currency of the browser cache. I often find I have to clear the browser cache (Firefox 102.2.0esr) or the selection window doesn't populate at all, and after I do the images come up randomly and keep resorting as they do so. I don't mind them popping in as the cache populates -- it's the resorting that causes me to click the wrong one. I also wish we had an "Undo" option, so at least I could undo the damage.

simonspa commented 1 year ago

I am having the same issue - in addition, merging people only works for one person at a time. If I go back to faces and click a different person and try to merge there, the dialog does not open. It requires a force-reload of the entire page (including all faces, veeeery slow) to work for the next person.

(cc) @marcelklehr

Sockolet commented 1 year ago

I am having the same issue - in addition, merging people only works for one person at a time. If I go back to faces and click a different person and try to merge there, the dialog does not open. It requires a force-reload of the entire page (including all faces, veeeery slow) to work for the next person.

(cc) @marcelklehr

same here. Also my CPU goes to 100% for all cores.