nextcloud / photos

📸 Your memories under your control
GNU Affero General Public License v3.0
580 stars 61 forks source link

Highlight which face was recognized on the picture #1541

Open MayeulC opened 1 year ago

MayeulC commented 1 year ago

Describe the feature you'd like to request

At the very least, when browsing a cluster under people, display a square in the area the face was detected.

Currently, I have to rely on the crop from the main "People" page for pictures that contain multiple people.

It's also hard to verify if the correct person was recognized when you don't know which face it is. As some clusters show pictures of objects with no human in sight, I don't have much faith in the accuracy.

Describe the solution you'd like

Ideally, put squares around people's faces everywhere, and allow the user to associate a name/existing person with it. That's how Sony did it CA 2014 on my phone, it worked pretty well.

When browsing pictures with multiple people, this would allow correcting mistakes and to assign names quickly.

Describe alternatives you've considered

Just displaying a square around faces in People -> X when viewing the full-size picture would help a lot with filtering pictures.

MayeulC commented 1 year ago

I just discovered memories. It has the bare minimum of displaying which face was detected in the preview.

However, it is quite terrible for group pictures: not only you can only see the square in the preview, you cannot see at a glance which faces were recognized and which were not.

Interestingly, Memories supports moving a picture to another cluster, which NC Photos does not.

marcelklehr commented 1 year ago

Interestingly, Memories supports moving a picture to another cluster, which NC Photos does not.

This is not the case. You can select an image in photos and use the three dot menu to move it to a different person.

marcelklehr commented 1 year ago

cc @nextcloud/designers

MayeulC commented 1 year ago

Interestingly, Memories supports moving a picture to another cluster, which NC Photos does not.

This is not the case. You can select an image in photos and use the three dot menu to move it to a different person.

NextCloud Photos' three dot menu:

image

Memories' :

image

NextCloud 25.0.2, with photos 2.0.1


Edit: unless the "merge with different person" does that, I just realized. However, I always assumed it would not, since this context menu item is present before selecting a photo; therefore I am assuming that it always operates on the whole cluster.

In fact, selection-specific menu items seem to make it clear from their menu items: download selected, remove photo from person.

marcelklehr commented 1 year ago

Huh, you're right. That's a missing feature indeed. Sorry.