search

nextcloud / photos

📸 Your memories under your control
GNU Affero General Public License v3.0
585 stars 62 forks source link

Allow photo upload on public-link shared album #1609

Open g-work opened 1 year ago

g-work commented 1 year ago

When receiving a public link to an album, you can only view the content but not add photos yourself. The [Hub 3 Announcement](Announcing Nextcloud Hub 3 - Brand New Design and Photos 2.0 with Editor and AI) says, “Futhermore, you can share the album with others using a public link so they can add their photos too.”.

How can this be achieved? I can't find the option.

To Reproduce Steps to reproduce the behavior:

  1. Create an album
  2. Share it my public link
  3. Open link on other device and try to add photo
  4. Doesn't work. Only viewing is possible

Expected behavior You should be able to "share the album with others using a public link so they can add their photos too.".

simonspa commented 1 year ago

Indeed you are right with what the announcement promised. However, right now sharing is relatively basic and by no means as configurable as the one in Files (i.e. being able to select whether a public link will allow editing or addition.

I therefore think that a public link - as a default - should not allow uploading, and that everything that goes beyond this we should consider a feature request rather than a bug.

To solve your immediate problem: you can still share an actual folder with pictures, which would allow uploading by third parties if configured accordingly.

miaulalala commented 1 year ago

So the API for public albums doesn't allow adding anyway at the moment: \OCA\Photos\Sabre\Album\PublicAlbumRoot::addFile throws a ForbiddenException.

So the button is dead code.

ChristophWurst commented 1 year ago

So the button is dead code.

@artonge would it be okay to hide the button for now?

artonge commented 1 year ago

There is no button, so nothing to hide. However, some recent changes removed the 'Delete' button to reduce the confusion/expectation around public albums: https://github.com/nextcloud/photos/pull/1749

st3iny commented 1 year ago

There is a button when the shared album is empty.

add-button-before

st3iny commented 1 year ago

I'll open a PR to fix this.

Shoggomo commented 1 year ago

Is this feature still being worked on? Would be nice, as the alternative is to create a folder for each album, which feels clunky.