Console error on Safari 14

[camilasan]

Describe the bug When you click on a Album, it does not open.

To Reproduce Steps to reproduce the behavior:

1. Go to 'apps/photos/albums'
2. Click on any album
3. Check the browser console
4. See error: SyntaxError: Unexpected private name #s. Cannot parse class method with private name. ChunkLoadError: Loading chunk vendor-node_modules_nextcloud_upload_dist_index_esm_js failed.

Expected behavior When you click on an Album, the page loads with the pictures from the Album.

Desktop (please complete the following information):

• OS: Mac OS Big Sur (MacOS 11.5.2)
• Browser: Safari
• Version Safari ver 14.1.2 (16611.3.10.1.6)

Browser log

Additional context This was specifically tested on Nextcloud 25.0.7.

[ChristophWurst]

The error is caused by https://github.com/nextcloud-libraries/nextcloud-upload using a ES language feature that is not present in Safari 14 but later versions. The packages uses https://github.com/nextcloud/babel-config but apparently not https://github.com/nextcloud/browserslist-config / https://github.com/nextcloud/browserslist-config/blob/master/browserlist.config.js. So the compiled ES might just have the wrong targets.

[skjnldsv]

AH, so we should just make sure not t ignore @nextcloud/upload from the transpiling here

[skjnldsv]

https://github.com/nextcloud/photos/blob/00515372dee2c4df3cd0687e5a7c48900ddacf73/webpack.js#L17-L20