nextcloud / photos

📸 Your memories under your control
GNU Affero General Public License v3.0
555 stars 61 forks source link

TypeError: Cannot read properties of undefined (reading 'key') #2558

Open DeanSabbah opened 1 month ago

DeanSabbah commented 1 month ago

Describe the bug When entering the Unassigned faces in the photos/people tab, the console logs this error. I am using the Recognize app for facial recognition.

To Reproduce Steps to reproduce the behavior: While using the Recgnize app

  1. Go to Photos
  2. Click on People, then unassigned faces
  3. See error

Expected behavior I assume the pictures should load and I should be able to manually assign the faces

Screenshots image

Desktop (please complete the following information):

Browser log

TypeError: Cannot read properties of undefined (reading 'key')
    at ma (vue.runtime.esm.js:6466:15)
    at vue.runtime.esm.js:6844:25
    at w (vue.runtime.esm.js:6933:21)
    at vue.runtime.esm.js:6807:17
    at w (vue.runtime.esm.js:6933:21)
    at vue.runtime.esm.js:6807:17
    at w (vue.runtime.esm.js:6933:21)
    at ki.nodeOps [as __patch__] (vue.runtime.esm.js:7101:17)
    at e._update (vue.runtime.esm.js:3785:25)
    at o.r (vue.runtime.esm.js:3891:16)

Additional Context After entering the unassigned faces tab, I can no longer change to any other tab within the Photos page (I can still switch to the files page).

hook-365 commented 1 month ago

I am receiving the same: Screenshot 2024-08-05 at 4 35 29 PM

TypeError: Cannot read properties of undefined (reading 'key')
    at ma (vue.runtime.esm.js:6466:15)
    at vue.runtime.esm.js:6844:25
    at w (vue.runtime.esm.js:6933:21)
    at vue.runtime.esm.js:6807:17
    at w (vue.runtime.esm.js:6933:21)
    at vue.runtime.esm.js:6807:17
    at w (vue.runtime.esm.js:6933:21)
    at ki.nodeOps [as __patch__] (vue.runtime.esm.js:7101:17)
    at e._update (vue.runtime.esm.js:3785:25)
    at o.r (vue.runtime.esm.js:3891:16)
Permanently commented 3 weeks ago

Also getting this. Seeming to find that unassigned faces are also not showing whatsoever, although I'm unsure whether this is a photos issue or a recognize issue.

DeanSabbah commented 3 weeks ago

I am almost certain that it is the photos app, as recognize works perfectly with the memories app.

Permanently commented 3 weeks ago

Good spot - just tried this myself. 100% the photos app.

justwiebe commented 1 week ago

For additional context, it looks like it happens in VirtualScrolling.vue#updateScrollPosition when you reach the bottom of the preloaded content

image
justwiebe commented 1 week ago

I don't know if this is related, but if I click on an image in "Unassigned Faces" to preview it, I get another undefined error:

image

Edit: I see this was fixed in https://github.com/nextcloud/photos/pull/2468 but I don't have that change, so I think I just need to upgrade my version for that