Edit chat messages - Githubissues

sunjam commented 5 years ago

How to use GitHub

Please use the 👍 reaction to show that you are interested into the same feature.
Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
Subscribe to receive notifications on status change and new comments.

Related to #774, but a different feature request. I'd like the ability to edit my chat messages in Talk. This is a common practice when dealing with typos, etc. and an expectation of common users.

Thanks for reading, and thanks for all your great work!

nickvergessen commented 5 years ago

That should work only in a limited case, otherwise it get's out of control:

No command was triggered
No mention was sent
No participant read the message already

ghost commented 5 years ago

Would it be possible to let the admin decide this? So that you can deactivate editing/deleting messages all together, maybe set a time limit or let the users do it whenever they want.

tiotrom commented 5 years ago

I second that! It would be very useful!

ruggdoll commented 4 years ago

Yes ! now about the limited cases mentionned by @nickvergessen , editing is a common feature in "enterprise grade" chats, because you have to use a proper language and that means editing, ultimately if you feel like implementing those limits is mandatory, then you should also allow us to untick those limits in the configuration.

Nyco commented 4 years ago

Most messengers that offer the "edit/correct message" feature:

allow this whatever the admin decides
allow this but only for the user's last sent message (not the ones sent nefore)
some messangers allow receivers to see the sender's original and edited messages

agentlibre commented 4 years ago

I believe this is an underestimated issue, which has a bad impact on a wider adoption for NextCloud talk. ⏩⏩⏩🚀

For several members within my organization, the lack of an editing/deleting feature in a direct message app is simply a no-go; I can't convince them that we should adopt NextCloud Talk for this single reason (despite other advantages, such as the integration with NextCloud Deck); they prefer RocketChat or Mattermost, where messages can be edited/deleted (and I understand this myself to some extend). 😥

For the record, I've found this issue mentioned elsewhere as well: https://help.nextcloud.com/t/talk-edit-just-sent-message-share-local-files/72756 🤔

I hope something could be done in a near future, this would be so great for the NextCloud environment and communities! 🤩🥰

nickvergessen commented 4 years ago

I hope something could be done about this rather promptly

Not the best way to communicate 🙈

I get the point, but for Person A having a grid view in the call is the most important thing, for Person B being able to moderate a call is the most important thing and for you it's editing of messages.

Please note that until a month ago the orientation line was more the chat messengers out there like Whatsapp, Threema, Signal, … and now the comparison line just expended quickly with Teams, Slack, Jitsi, … because of corona. Feel free to help out and get involved. Any help counts, not only coding. But until then the items we can work on are rather limited.

agentlibre commented 4 years ago

I hope something could be done about this rather promptly

Not the best way to communicate see_no_evil

Yes, sorry, I've noticed this once the message was published and was happy to have... an editing option! 😉

I get the point, but for Person A having a grid view in the call is the most important thing, for Person B being able to moderate a call is the most important thing and for you it's editing of messages.

Sure, sure, just wanted to share this testimony because, in my case, this single factor has been decisive for some common (and rather Nextcloud-friendly) users.

Please note that until a month ago the orientation line was more the chat messengers out there like Whatsapp, Threema, Signal, … and now the comparison line just expended quickly with Teams, Slack, Jitsi, … because of corona.

Feel free to help out and get involved. Any help counts, not only coding. But until then the items we can work on are rather limited.

I perfectly understand the situation. I have no tech skills but I'm actively advocating FOSS and, first and foremost NextCloud, which is the best "gateway drug" in my opinion (also thanks to the AGLPv3 choice in addition to the wonderful software it is). That's precisely why I'm raising this issue: I would like to be able to convince more people to come on board (and truth be told, it could scale up very fast from where I'm standing) but I need the arguably basic features to be in place to do so.

I don't want to be a party pooper though: I greatly appreciate the work that has been and is being done! 🙏

jasondaigo commented 4 years ago

I used rocketchat mattermost and matrix just now during corona times. I only use nextcloud on private installation. Not implementing edit or delete seem a bit stubborn to me. In a Sega / Blackberry way (huge fan though) 🙂

nickvergessen commented 4 years ago

Feel free to help out and get involved. Any help counts, not only coding. But until then the items we can work on are rather limited.

graue70 commented 3 years ago

That should work only in a limited case, otherwise it get's out of control:
* No command was triggered
* No mention was sent
* No participant read the message already

I know nothing about the technical difficulties involved but it would annoy me if I couldn't fix the bad typo in my last message only because I mentioned somebody in it.

Feel free to help out and get involved.

If I wanted to implement this, would it be enough to change the string in the database or is there something else that needs to be done?

nickvergessen commented 3 years ago

See https://github.com/nextcloud/spreed/pull/4861#issuecomment-753967049

graue70 commented 3 years ago

Since the last message id of a conversation is set and the messages are downloaded by our mobile clients, deleting from the DB is not a good idea and doesn't help a lot. Instead we should only wipe the content of the message (if the database structure allows it to be empty) and at the same time we need to add a "hidden" message that the message with ID X was deleted, so the clients can remove the message from their local store as well.

To clarify my question: Is this comment also true for editing messages? If so, wouldn't it be a better solution to have some kind of event telling clients to reload a specific message from the database?

Or in other words: Do you think your suggestion is the best solution or only the easiest to achieve?

AxelRothe commented 3 years ago

I second this motion.

We recently switched from Slack to Talk and for the most part are very happy. But the lack of editing a posts, makes it hard to create pinned or dynamic posts. THINK BOTS! 🤖

A bot needs to be able to change their post. Otherwise the Bot might spam small posts for every reply instead of simply updating a post that leads to a better overview. i.e. a daily stand up bot, that can post a list of users that have not submitted a stand up and update it as users add their posts.

We moved to Nextcloud Talk for the ability to actively help development. Is there a way for us to help with this issue? We have developers.

nickvergessen commented 3 years ago

There is an easier part (modifying the server + web UI) and a harder part (making sure all the mobile clients reflect this correctly as well). I guess looking at the PR of "Delete messages" can give quite a good view and template for edits. But then we need to make sure mobile clients also understand the new system message and update the old messages accordingly.

dtcg commented 3 years ago

Any updates on this?

edmundlaugasson commented 3 years ago

Is Talk message editing now possible with Nextcloud 22?

le-patenteux commented 3 years ago

I can't find the option in my instance of Nextcloud. Is this feature coming? Where does it stand in the priority list? I can simply not convert my business to use Talk vs Teams because of that one missing bit... the rest is A-Ok !

Have a nice day

nickvergessen commented 3 years ago

It's not on our todo list at the moment, as we are currently focusing on calls and meetings

edmundlaugasson commented 2 years ago

Unfortunately still not implemented even in great 23th version :(

sunjam commented 2 years ago

I'll follow up here having just read this forum comment and watching the 23 announcement video where chat editing is discussed.

What is the most compelling reason to support message editing? (from the video)

Every chat platform I use supports editing: Matrix, Slack, Discord, Rocket.chat, IRC, etc. over the last couple years. I've personally bridged all of these platforms on a per room basis via Matrix and editing is supported across all participants on all platforms.

So, this is something I'm just used to having. No worries on if it isn't implemented; I just won't be migrating away without it.

le-patenteux commented 2 years ago

I would like to know If this issue has been adressed yet... Can't find documentation on the matter. My company would switch 100% from O365 to Nextcloud if this was fixed (I said fixed, because the lack of Chat messagess editing for a business application is a bug, not a feature in 2022)

So what i am saying, and I have read a lot from various sources, is that Nextcloud is missing on real, enterprise level, paying/contributing customers because of the lack of chat messages editing... This is huge!

If the feature has indeed been implemented, can someone point me to documentation on how to activate it?

sunjam commented 2 years ago

Nope, no change

On Tue, Oct 4, 2022, 5:32 PM Normand_Nadon @.***> wrote:

I would like to know If this issue has been adressed yet... Can't find documentation on the matter. My company would switch 100% from O365 to Nextcloud if this was fixed (I said fixed, because the lack of Chat messagess editing for a business application is a bug, not a feature in 2022)

So what i am saying, and I have read a lot from various sources, is that Nextcloud is missing on real, enterprise level, paying/contributing customers because of the lack of chat messages editing... This is huge!

If the feature has indeed been implemented, can someone point me to documentation on how to activate it?

— Reply to this email directly, view it on GitHub https://github.com/nextcloud/spreed/issues/1836#issuecomment-1267188949, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANUKZTXCQZCZEFP23QAPTTWBREXXANCNFSM4HN2YXOQ . You are receiving this because you authored the thread.Message ID: @.***>

le-patenteux commented 2 years ago

I know it is an issue tracker and not a chat forum here, but it amazes me that this issue is not taken care of since 2019 and is the no-go for many real enterprise level customer... I tried to start a migration project for my company and it was one of the top 3 deciding factor not to do it! In fact, it was the nail in the coffin (the two other were change management for the employees and some issues related to our use of PowerBi that could both be overcomed)

Now, more constructive comment, how I envision the feature: Feature: Ability to edit a message, it is self explanatory

Administration of said feature Maybe add a set of rules for messages editing:

edit messages feature -> off / on
Message can be edited after they were read -> no / yes
Maximum delay before message editing -> no / yes (enter time delay in minutes)
Some other options related to message linking and interractions with other apps to avoid breaking the system (can't tell about those one with my current knowledge)

Have a nice day all :)

sunjam commented 2 years ago

I do wonder about editing in regards to Matterbridge support in Talk, since other modern chat platforms do include edit functionality. My experience is edits currently lead to you seeing each iteration when you are bridged from irc.

On Tue, Oct 4, 2022, 6:08 PM Normand_Nadon @.***> wrote:

I know it is an issue tracker and not a chat forum here, but it amazes me that this issue is not taken care of since 2009 and is the no-go for many real enterprise level customer... I tried to start a migration project for my company and it was one of the top 3 deciding factor not to do it! In fact, it was the nail in the coffin (the two other were change management for the employees and some issues related to our use of PowerBi that could both be overcomed)

Now, more constructive comment, how I envision the feature: Feature: Ability to edit a message, it is self explanatory

Administration of said feature Maybe add a set of rules for messages editing:

edit messages feature -> off / on

Message can be edited after they were read -> no / yes

Maximum delay before message editing -> no / yes (enter time delay in minutes)

Some other options related to message linking and interractions with other apps to avoid breaking the system (can't tell about those one with my current knowledge)

Have a nice day all :)

— Reply to this email directly, view it on GitHub https://github.com/nextcloud/spreed/issues/1836#issuecomment-1267238154, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANUKZQFDWNOXRLUC2JVUELWBRJAZANCNFSM4HN2YXOQ . You are receiving this because you authored the thread.Message ID: @.***>

le-patenteux commented 2 years ago

Could a developer on the project respond to the thread please just to let us know the status of this feature request.

Is it considered or not?
Is it planned?
Is it parked to deal with later?

Just please inform the community about this feature, because as I said, and other did, it is the only show-stopper remaining for adoption in our business ! This single features makes it that we can't consider migrating the entire business to Nextcloud!

Good say to the team, and keep-up with the amazing work you do!

edmundlaugasson commented 1 year ago

Certainly sent message editing is crucial. But I would say, that also sending without sound and scheduling messages are also important, e.g. like in Telegram. Also videoconversation recording - if we have cloud storage as Nextcloud has, then why we cannot record conversations? Besides, I had issues with Talk in case of more participants. If there are tens of users, then already will be issues with sound, screen sharing doesn't work, etc. Also I experienced sharing is challenging, e.g. simple folder sharing but not only - also other resources sharing is challenging, other participants just cannot see these shares. In case of AD you need to know exact ID and cannot use real name. Also sync between AD does not work - user has to be logged at least once in and then can be shared. These are my experiences in larger organization with Nextcloud.

yjjoe-head commented 1 year ago

bump! any approximation ETA for that issue?

benfavre commented 1 year ago

Need this

ihard commented 1 year ago

I will support the question about implementation plans? Or the functionality cannot be implemented for some reason?

mophilly commented 1 year ago

It's not on our todo list at the moment, as we are currently focusing on calls and meetings

What is needed to move this forward? I am wondering about skills, a task list, and how a volunteer could help. Not general, but specific to this topic, please.

mophilly commented 1 year ago

I am willing to take a look, but like everyone, my free time is limited.

If someone could point me to the segments dealing with adding and deleting posts in talk channels, that would save me a few hours of reading code not related to the edit functions. Perhaps I can help move this forward.

BTW, the reason I am posting again is I am advocating adoption of NC Talk, and get a complaint about users not able to edit almost every day.

AnAnalogGuy commented 1 year ago

So it seems the NC team has decided to no take this request into their backlog or roadmap. Would be nice to get a confirmation.

Second, is the NC team able to provide a rough estimation of the expected effort for this feature to be implemented? Do you guys have an idea how to do it? Since, the moment we have some figures/tasks, the community might be able to jump in and provide code and resources. But it needs a kind of plan first to direct the whole activities.

edmundlaugasson commented 1 year ago

I would say, that NC team has not decided it as we don't see any official confirmation. Would be reasonable not rely on guesses. As far as I know but not completely sure either, there is lack of developers and possibly other resources. I truly hope, that this news https://nextcloud.com/blog/eu-governments-bet-on-nextcloud-to-replace-sharepoint/ brings more money and developers to Nextcloud and it will be developed more diligently and faster. So, thumbs up and keep going!

AnAnalogGuy commented 1 year ago

Actually it's not a guess, it's called deduction. Quite simple. Open since 2019, we have 2023, 4 years, no one picked it up.

gymnae commented 1 year ago

+1 This feature is a must-have. All other platforms have it. Maybe another argument why integrating Matrix instead of re-inventing the wheel would've been a good choice.

nickvergessen commented 1 year ago

Whatsapp added it now with a 15 minute limit: https://blog.whatsapp.com/now-you-can-edit-your-whatsapp-messages

edmundlaugasson commented 1 year ago

What's app added it now with a 15 minute limit: https://blog.whatsapp.com/now-you-can-edit-your-whatsapp-messages

Nextcloud should have it without limits. Otherwise people choose something else.

q-wertz commented 1 year ago

I like the way Mattermost handles it. The admin can set a limit for how long the message can be edited.

There are scenarios where you do not want that every message is editable for always (and there is not trace what the original message was)

edmundlaugasson commented 1 year ago

That's true - this message editing feature should be configurable per chat to fit all needs.

nickvergessen commented 1 year ago

Mostlikely we will use the same limitation as for deleting. But more to be decided by the design team.

dem36rus commented 1 year ago

+1 need this function

NoahDar commented 1 year ago

I too would love to see this happen in Talk. Just throwing it out there.

alauzon commented 1 year ago

I am volunteering to do it if someone leads me into the code.

nickvergessen commented 1 year ago

Well, it's kind of a lot of places. Checking the code from the delete could be a good pointer: https://github.com/nextcloud/spreed/pull/4861

But afterwards we need mobile apps to be able to understand the messages, before we can merge the work

alauzon commented 1 year ago

Thank you for your answer, Joas.

And when you say "But afterwards we need mobile apps to be able to understand the messages, before we can merge the work" which code is implied in that? The spreed app and/or the Nextcloud Talk app on Android and iPhone?

nickvergessen commented 1 year ago

Android and iOS apps yeah. They save messages locally, so they need to understand the editing message to update the previous message.

alauzon commented 1 year ago

Android and iOS apps yeah. They save messages locally, so they need to understand the editing message to update the previous message.

How can we do that? If the messages are saved locally is there a mechanism to tell the phone apps to modify it? Maybe the delete does something similar also?

nickvergessen commented 1 year ago

Exactly, there are messages which tell them "hey delete the message with ID x" and for edit we basically need "hey refresh the content of the message with ID x"

NoahDar commented 1 year ago

Also, there's been a suggestion that the ability to edit the message should expire after 15 minutes to keep resources down. Any thoughts?

nextcloud / spreed

Edit chat messages #1836

How to use GitHub

What is the most compelling reason to support message editing? (from the video)