search

nextjournal / markdown

A cross-platform clojure/script parser for Markdown
ISC License
46 stars 6 forks source link

Drop GraalJS in favour of Commonmark Java #25

Closed zampino closed 1 week ago

zampino commented 5 months ago

This switches the implementation for when using this library from the JVM from markdown-it to commonmark-java. We use generative testing to compare both implementations return the same markup.

This comes with an approximate speedup of 10x and fixes #23.

holyjak commented 2 months ago

Hello! Is there any timeframe for finishing this? Asking due to https://github.com/scicloj/wolframite/issues/56 ... Thank you!

zampino commented 2 months ago

Hello! Is there any timeframe for finishing this? Asking due to scicloj/wolframite#56 ... Thank you!

We're doing some progress, but there's not really a timeframe yet. For the moment you might use the workaround mentioned in https://github.com/nextjournal/clerk/issues/642#issuecomment-2032310246 (i.e. use #24 as dependency from github).

holyjak commented 2 months ago

Ok, thank you!