nf-osi / kairos

kairos: NF Analysis Explorer
Other
0 stars 2 forks source link

heatmap function #31

Open allaway opened 4 years ago

allaway commented 4 years ago

Let's converge on one heatmap solution. There's currently fct_heatmap, repurposed from iAtlas, that calls plotly directly, though I don't think either of us are actually using this. @jaybee84 is using heatmaply, which calls plotly via a heatmap library. @allaway wrote a basic plotly function for drug vis, but this heatmap does not look so good.

@jaybee84 , how has your testing with heatmaply gone? Is it worth adding another dependency for the extra functionality over just using plotly alone?

jaybee84 commented 4 years ago

heatmaply is easy to implement and is quite configurable .... but still working on resizing it ...

right now it looks like this : image

allaway commented 4 years ago

Oh, i couldn't visualize what you were describing, but I've seen this frequently with plotly-based viz, only in shiny. I'm not sure what causes it or how to resolve it, though. I would post to #r slack channel, or ask someone like James or Andrew.

allaway commented 4 years ago

In other words, i don't think this is a heatmaply issue, but rather a plotly-in-shiny issue.

jaybee84 commented 4 years ago

Ah! will post to #r ASAP!