search

nfroidure / gulp-svgicons2svgfont

Bundle several SVG icons to a single SVG font
MIT License
45 stars 20 forks source link

Add color property to glyphs event #31

Closed TylerYang closed 8 years ago

TylerYang commented 8 years ago

Add color property to glyphs event, color might be undefined if there is not fill attribute in svg element. But I think it's better to pass it to developer to define what default value it should be.

TylerYang commented 8 years ago

This failed due to svgicons2svgfont PR is not accepted.

TylerYang commented 8 years ago

Seems you need to publish a new svgicons2svgfont version to npm, and update the version number of svgicons2svgfont in package.json dependency. How about with a _latest_ tag?

That can make sure the _CI_ will run all the test cases in a proper environment. (e.g https://github.com/nfroidure/svgicons2svgfont/pull/48).

A small proposal I think it will be better to trigger an auto release task after each merge action, and publish a new version(with _latest_ tag ) to npm.

This will make sure whenever there is a new PR being merged into our master, our 3rd party developer can install with _lastest_ tag right away.

nfroidure commented 8 years ago

Merged