search

nfroidure / gulp-svgicons2svgfont

Bundle several SVG icons to a single SVG font
MIT License
45 stars 20 forks source link

Emit hex version of codepoint #8

Closed backflip closed 10 years ago

backflip commented 10 years ago

As discussed in https://github.com/backflip/gulp-iconfont-css/issues/9

nfroidure commented 10 years ago

After some thinking, i think the best is to keep codepoints as integers, for compatibility reasons, but also cause it is the more memory efficient way to store the information.

Imha, a plugin responsibility is to provide information in an universal and lightweight format instead of assuming which usage users will make of its information. As pointed out by your PR, doing a codepoint.toString(16) is simple enough to let users manage this conversion.

I'll add it to the usage section of the REAME to help users but wont merge this PR. Sorry 'bout that, hope you'll agree on my thoughts.

backflip commented 10 years ago

Sounds absolutely reasonable.