refactor: 💡 change requestDataChanged argument type - Githubissues

ngneat / cashew

🐿 A flexible and straightforward library that caches HTTP requests in Angular

https://www.netbasal.com

MIT License

682 stars 33 forks source link

refactor: 💡 change requestDataChanged argument type #68

Closed ritox842 closed 2 years ago

ritox842 commented 2 years ago

PR Checklist

Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

fix type of requestDataChanged first argument to support 'undefined'. also, changed the names of the arguments to be more accurate.

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

requestDataChanged accepts only HttpRequest

Issue Number: N/A

What is the new behavior?

requestDataChanged accepts HttpRequest | undefined

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information