ngneat / cashew

🐿 A flexible and straightforward library that caches HTTP requests in Angular
https://www.netbasal.com
MIT License
682 stars 33 forks source link

Angular 14 support #79

Closed sambernet closed 1 year ago

sambernet commented 2 years ago

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[X] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

Angular 13 is used for the project currently. The README.md doesn't give any information about supported angular versions

Expected behavior

I am aware that the library package.json has a peer dependency towards angular 13+ - so it's possible the library works just fine with angular 14 (which is really cool and should be adopted by more angular 3rd party libs πŸ‘ )

But I'm currently mapping out the migration path for a large project with a lot of dependencies, and I was wondering if cashew has already been tested with angular 14? Maybe somebody has experience migrating this already?

Then I thought it would be nice to actually provide angular compatiblity information in the main readme of the repository.

Alternatively upgrading the whole library to angular 14 would also resolve my question, of course 😁

Minimal reproduction of the problem with instructions

n/a

What is the motivation / use case for changing the behavior?

Angular 14 was released on June 02, 2022 and is becoming adopted more and more widely. In November we already expect ng15 to hit the road. Cashew is one of the last libraries for my specific ng 14 upgrade that is not confirmed yet to be ng 14 compatible.

Environment

Angular 14

NetanelBasal commented 2 years ago

Sounds good :) You're welcome to create a PR.

sambernet commented 1 year ago

Dammit, you beat me to it πŸ˜‚ Thanks πŸš€