fix(local-storage): set http headers correctly

muuvmuuv commented 9 months ago

PR Checklist

Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: CONTRIBUTING.md#commit
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #95

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This also adds single definition of cache key, from perf perspective this makes sense:

Open for link

https://perf.link/#eyJpZCI6IjJnOWF3bmt3MmkzIiwidGl0bGUiOiJGaW5kaW5nIG51bWJlcnMgaW4gYW4gYXJyYXkgb2YgMTAwMCIsImJlZm9yZSI6ImNvbnN0IGRhdGEgPSBbLi4uQXJyYXkoMTAwMCkua2V5cygpXVxuXG5mdW5jdGlvbiBjcmVhdGVLZXkoa2V5KSB7XG4gIHJldHVybiBgc29tZS0ke2tleX1gO1xufSIsInRlc3RzIjpbeyJuYW1lIjoiRG91YmxlIGV4ZWMgdy9vIGRlZmluZSIsImNvZGUiOiJkYXRhLmZvckVhY2goeCA9PiB7XG4gIGNyZWF0ZUtleSh4KVxuICByZXR1cm4gY3JlYXRlS2V5KHgpXG59KSIsInJ1bnMiOls4MDAwLDExMDAwLDEwMDAsMTEwMDAsMTAwMCwxMDAwLDQwMDAsMTAwMCw0MDAwLDIwMDAsOTAwMCw0MDAwLDEwMDAsMjQwMDAsMTkwMDAsMTAwMCw1MDAwLDEwMDAsNzAwMCwxMDAwLDEwMDAsMTYwMDAsMTAwMCw5MDAwLDYwMDAsMjAwMCwxMDAwLDUwMDAsNzAwMCwyMTAwMCwzMDAwLDEwMDAsMjYwMDAsMzAwMCw0MDAwLDYwMDAsNjAwMCwxMDAwMCw5MDAwLDExMDAwLDEwMDAsMjAwMCwyMDAwLDEwMDAsMjQwMDAsMTEwMDAsNzAwMCwxMjAwMCwxMTAwMCw0MDAwLDYwMDAsMTAwMCw2MDAwLDUwMDAsMjEwMDAsMTAwMCwxNDAwMCwxMDAwLDkwMDAsMTIwMDAsMTAwMCwyMTAwMCwxMjAwMCwxMDAwLDEwMDAsNTAwMCwyMDAwMCwxMjAwMCw5MDAwLDEwMDAsMTEwMDAsMjMwMDAsMjAwMCwxODAwMCwxMzAwMCwxMDAwLDEwMDAsOTAwMCwyMDAwMCwxMDAwMCwxOTAwMCwxMjAwMCw3MDAwLDkwMDAsMjAwMCwxMDAwMCwyNTAwMCw3MDAwLDYwMDAsMTIwMDAsNTAwMCwxMDAwLDEwMDAwLDgwMDAsMzAwMCwxMDAwLDIxMDAwLDI2MDAwLDE2MDAwLDEwMDBdLCJvcHMiOjgwNzB9LHsibmFtZSI6IlNpbmdsZSBleGVjIGFuZCBkZWZpbmUiLCJjb2RlIjoiZGF0YS5mb3JFYWNoKHggPT4ge1xuICBjb25zdCBrID0gY3JlYXRlS2V5KHgpXG4gIHJldHVybiBrXG59KSIsInJ1bnMiOlsxMjAwMCwxMDAwMCwyMDAwLDE5MDAwLDEwMDAsMTAwMCw5MDAwLDIwMDAsNzAwMCwzMDAwLDIwMDAwLDYwMDAsMTAwMCw0MjAwMCwzNzAwMCw0NTAwMCw3MDAwLDIwMDAsMTQwMDAsMTAwMCw0MzAwMCwzMjAwMCw0MDAwLDI2MDAwLDExMDAwLDQwMDAsMTAwMCw3MDAwLDEwMDAwLDM5MDAwLDQwMDAsMTAwMCw0NTAwMCw1MDAwLDcwMDAsOTAwMCwxMTAwMCwyMTAwMCwxOTAwMCwxODAwMCwyMDAwLDMwMDAsMjAwMCwyMzAwMCwzODAwMCwyMDAwMCwxOTAwMCwxMzAwMCwyMjAwMCwxMDAwMCwxMTAwMCw0NTAwMCw4MDAwLDQwMDAsNDIwMDAsMjAwMCwxOTAwMCwzNzAwMCwyNjAwMCwyODAwMCwyMDAwLDQxMDAwLDIxMDAwLDEwMDAsMzEwMDAsODAwMCwzNTAwMCwzMjAwMCwxOTAwMCwyMDAwLDE5MDAwLDQwMDAwLDQwMDAsMzAwMDAsMzMwMDAsNDUwMDAsMjEwMDAsMjMwMDAsMzgwMDAsMjUwMDAsMzAwMDAsMjIwMDAsMTUwMDAsMTkwMDAsNDAwMCwxNDAwMCw0NTAwMCwxNTAwMCwxNDAwMCwxNDAwMCwxMjAwMCwxMDAwLDE4MDAwLDcwMDAsMzAwMCwxMDAwLDMzMDAwLDQ1MDAwLDIwMDAwLDQwMDBdLCJvcHMiOjE3MzgwfV0sInVwZGF0ZWQiOiIyMDI0LTAxLTAxVDE1OjI2OjIwLjU1NloifQ%3D%3D

fixes #95

stackblitz[bot] commented 9 months ago

Run & review this pull request in StackBlitz Codeflow.

muuvmuuv commented 9 months ago

Isn‘t that tested due to my change in the mock? I also noticed that the clearCachePredicate does not have a previous value in the browser when one is in localStorage, any idea why?

NetanelBasal commented 9 months ago

You should test that the current headers persists

muuvmuuv commented 9 months ago

Do you mean like this?

NetanelBasal commented 9 months ago

The build is stuck from some reason. Did you run the tests locally and they pass?

muuvmuuv commented 9 months ago

I did yes. I will have a look the next days

muuvmuuv commented 9 months ago

Seems to be related to GH Actions configuration and runner uptime https://github.com/ngneat/cashew/actions/runs/7378588007

ngneat / cashew