Closed gzlock closed 6 years ago
@gzlock First of all, thanks for your contributions~ you're really helping me in many ways :)
But bad news in that your pull request is not working. I thing that you've fixed a bug in Decoding the packet. So please make new pull request except modifing readme.md. And there's the feature branch - support-socket.io-v2 - which is working on upgrade to socket.io V2. Please set the target remote branch as 'support-socket.io-v2' not 'master'
In socket.io V2, the packet structure is totally changed and we have to implement Encoder and Decoder from the bottom up.
This link is socket.io-client-Javascript github. In 'lib' folder you can find new rules of encoding and decoding the packet in socket.io V2. (I'm also reviewing this file~)
@ppz0th I uncommonly used github, this is my first pull request 😂 I just tested the client connected socket.io v2 server success without error , I did not think socket.io changed so much. Sorry about that.
@gzlock Please, before changes can be accepted a Contributor Licensing Agreement for Individual | Corporate must be completed
Thank you your Contribute code!
Test passed. Dev env: