search

ni / measurement-plugin-python

Python framework to develop measurement plug-ins for NI application software. Contains sample measurement plug-ins for InstrumentStudio and TestStand.
MIT License
19 stars 15 forks source link

Change the generator tool name to ni-measurement-plugin-generator #798

Closed dixonjoel closed 3 months ago

dixonjoel commented 3 months ago

What does this Pull Request accomplish?

Changes the name of the plugin generator command to ni-measurement-plugin-generator. image

Why should this Pull Request be merged?

We want to change the way users invoke the generator so they don't get confused. ni-measurement-plugin-sdk-generator could indicate you're 'generating a plugin SDK'.

What testing has been done?

Ran the tool locally.

github-actions[bot] commented 3 months ago

Test Results

    30 files  ±0      30 suites  ±0   46m 24s :stopwatch: +22s    653 tests ±0     653 :white_check_mark: ±0      0 :zzz: ±0  0 :x: ±0  16 210 runs  ±0  15 150 :white_check_mark: ±0  1 060 :zzz: ±0  0 :x: ±0 

Results for commit 9e4a5705. ± Comparison against base commit ac37644a.

bkeryan commented 3 months ago

@dixonjoel Will the client generator be part of the same PyPI package and named ni-measurement-client-generator?

dixonjoel commented 3 months ago

@dixonjoel Will the client generator be part of the same PyPI package and named ni-measurement-client-generator?

I'm not sure about if it'll be in the same packages, but yes, I think that's what @rfriedma and I talked about.