Update default channel pool options when creating grpc channels - Githubissues

ni / measurement-plugin-python

Python framework to develop measurement plug-ins for NI application software. Contains sample measurement plug-ins for InstrumentStudio and TestStand.

MIT License

19 stars 15 forks source link

Update default channel pool options when creating grpc channels #887

Closed jasonmreding closed 1 month ago

jasonmreding commented 1 month ago

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?

Updates the channel pool so that by default it:

Does not limit the size of messages that can be sent across a channel.
Disables http proxy if it determines the target address is for the localhost. DNS lookups are not performed as part of this calculation for simplicity and performance for what is expected to be the most common scenarios.

Why should this Pull Request be merged?

This minimizes support issues with http proxies that are often difficult to diagnose.

What testing has been done?

Added unit tests for logic which determines whether an address string is for the localhost or not.
I manually tested with the http_proxy environment variable set before and after this change. I validated that example measurements fail to start successfully before the change (can't connect to discovery when trying to register themselves), and they start successfully after this change.

github-actions[bot] commented 1 month ago

Test Results

30 files ± 0 30 suites ±0 45m 25s :stopwatch: + 6m 40s 665 tests + 14 665 :white_check_mark: + 14 0 :zzz: ±0 0 :x: ±0 16 550 runs +420 15 480 :white_check_mark: +420 1 070 :zzz: ±0 0 :x: ±0

Results for commit 56d048e6. ± Comparison against base commit d67c2443.

:recycle: This comment has been updated with latest results.