search

nick42d / youtui

TUI and API for YouTube Music written in Rust
MIT License
30 stars 2 forks source link

add support for rustls #26

Closed hungl6844 closed 2 months ago

hungl6844 commented 2 months ago

because openssl is a pain to cross-compile for, I have added the ability for users to switch to another backend instead. since the only configuration required to do so is enabling the features in reqwest, all I had to do was add a feature in ytmapi-rs that tells reqwest to switch the backend.

nick42d commented 2 months ago

Hi @hungl6844 , cheers for the PR! Looks like there is a GtiHub issue blocking CI, bear with me while that gets resolved.

nick42d commented 2 months ago

Does this approach still use reqwest default features by default? That's my preference for now.

hungl6844 commented 2 months ago

First of all, yes, by default, openssl is still used when building the binary, the feature “rusttls-tls” is required to switch away. Thanks for pointing out the issues, I didn’t even realize the binary wasn’t building (I was only using ytmapi-rs, so I never built youtui). I will implement your changes as soon as possible!

nick42d commented 2 months ago

Made some slight changes, if you're happy with that I'll get this merged!

hungl6844 commented 2 months ago

Go for it!

nick42d commented 2 months ago

Go for it!

We're in - thanks for your contrib :) In future I'll look to improve this slightly to work around case where multiple features are specified - issue #30 added for tracking.