search

nickspeal / musicThisWeek

A Web Service that generates a Spotify playlist of bands that are playing in your area in the near future
3 stars 2 forks source link

Add tests to verify that eventful results meet search criteria #36

Open nickspeal opened 8 years ago

esmason commented 8 years ago

can you expand on this briefly? Is this a test of us parsing search arguments correctly or the eventful API ?

nickspeal commented 8 years ago

We've previously seen issues with the events coming back from eventful being out of the specified date range. Turns out this might have been caused by sending it an invalid date range, i.e "Next 14 days" maybe?

In any case, at some point I'd like to test some high number of searches for different places and times and confirm that the events returned match the parameters we send.

esmason commented 8 years ago

Limit this list of results to a date range, specified by label or exact range. Currently supported labels include: "All", "Future", "Past", "Today", "Last Week", "This Week", "Next week", and months by name, e.g. "October". Exact ranges can be specified the form 'YYYYMMDD00-YYYYMMDD00', for example '2012042500-2012042700'; the last two digits of each date in this format are ignored.

by this is looks like maybe even Next 7 days is not valid. Regardless lest check it out. looks like the relevant fields to check in eventful are start_time and stop_time in the events JSON array http://api.eventful.com/docs/events/search