search

nielsboecker / HoloRepository-HoloLens

A system for transforming medical imaging studies into holograms, storing them in the cloud and providing them to other systems.
GNU Affero General Public License v3.0
4 stars 0 forks source link

Lens/fake smart auth #13

Closed fanbomeng97 closed 5 years ago

fanbomeng97 commented 5 years ago
nielsboecker commented 5 years ago

Hey, what do you mean when you say "Still can not get p104, p105, p106"? Is this something @boonwj can help you with?

nielsboecker commented 5 years ago

I have the Accessor running and it seems to work (200 response accoding to the log) image

When I do the same query in the browser, I get: image

I guess this is actually expected, cause Wenjie just added holograms for some patients (see README)

But: image

and: image

fanbomeng97 commented 5 years ago

@nbckr it seems like the birthdate of p100 is missing, so it will have this error, i will add an error handler we are using the different accessor version, it works fine on my pc, image

fanbomeng97 commented 5 years ago

image

nielsboecker commented 5 years ago

Okay yeah. It would be good if you can handle most errors gracefully and just show "Unknown" if a field like birthDate is missing.

nielsboecker commented 5 years ago

Okay now I see patients. When I want to open a hologram however, there is a 500 error in the Accessor. I am using the current dev branch version. Don't you get the same?

image

REST Error: 500
{"errorCode":"500","errorMessage":"-\u003e github.com/Azure/azure-storage-blob-go/azblob.newStorageError, C:/Users/niels/go/src/github.com/Azure/azure-storage-blob-go/azblob/zc_storage_error.go:42\n===== RESPONSE ERROR (ServiceCode=BlobNotFound) =====\nDescription=The specified blob does not exist.\nRequestId:77aac71f-b01e-0073-4035-59737f000000\nTime:2019-08-22T22:02:19.4842942Z, Details: \n   Code: BlobNotFound\n   GET https://holoblob.blob.core.windows.net/holograms/h103?timeout=61\n   Authorization: REDACTED\n   User-Agent: [Azure-Storage/0.7 (go1.12.7; Windows_NT)]\n   X-Ms-Client-Request-Id: [e81c38dc-e0d3-4e44-6adb-ad79262cede2]\n   X-Ms-Date: [Thu, 22 Aug 2019 22:02:17 GMT]\n   X-Ms-Version: [2018-11-09]\n   --------------------------------------------------------------------------------\n   RESPONSE Status: 404 The specified blob does not exist.\n   Content-Length: [215]\n   Content-Type: [application/xml]\n   Date: [Thu, 22 Aug 2019 22:02:19 GMT]\n   Server: [Windows-Azure-Blob/1.0 Microsoft-HTTPAPI/2.0]\n   X-Ms-Error-Code: [BlobNotFound]\n   X-Ms-Request-Id: [77aac71f-b01e-0073-4035-59737f000000]\n   X-Ms-Version: [2018-11-09]\n\n\n"}

My settings are

export AZURE_STORAGE_ACCOUNT=holoblob
export AZURE_STORAGE_ACCESS_KEY=ri8F+lX6vu3i5FfMnjhz0uP8SvuYEgY26Gd8ZPYKyihue4a9ylj6Y7RsehrwFhlfZCWNgbqkqzFbN0TSPowVRg==
export ACCESSOR_FHIR_URL=https://holostorage.azurewebsites.net
export ENABLE_CORS=true
nielsboecker commented 5 years ago

Okay. That is important information for me as the reviewer ;) With these settings, it works for me too. Cool then.

Btw maybe an empty patient should be a warning rather than an error log statement, as it is currently expected behaviour. (I would not change the hard-coded PIDs, cause now when I upload new data for these patients, they will show up on your end in the future)