search

nikini / ionic-gallery-modal

Ionic Gallery Modal (to show all your photos)
166 stars 80 forks source link

Error with Ahead of Time #2

Closed martinop closed 7 years ago

martinop commented 7 years ago

Hi, This is a nice lib for gallery but I have a problem when try to compile with AoT the problem:

Unexpected value 'GalleryModal' declared by the module 'AppModule'

nikini commented 7 years ago

Can you show me you AppModule code? Seems like you haven't imported the GalleryModal

krooshua commented 7 years ago

Same issue when running production build

ionic build --prod --release

GalleryModal imported to AppModule and added to declarations and entryComponents

nikini commented 7 years ago

I have an updated version. Will be updating this soon. I think that may fix it

nikini commented 7 years ago

Can you check the new version?

nikini commented 7 years ago

The problem is a bit more complex. Ionic has removed a lot of functionalities. Back to the sketchboard. I'll be commiting a new version these days.

nikini commented 7 years ago

Fixed it for Ionic RC5 and fixed the other stuff. Can you please check now? v0.0.8

Otherwise, please provide a code example

martinop commented 7 years ago

Thanks, i will try

marcelofb commented 7 years ago

Hi, the error continues :(

nikini commented 7 years ago

I'm working on the bug. So far, as a workaround, if it's urgent, you can take the classes from the source of this repo and use them within your project

shyamal890 commented 7 years ago

Hmm, facing the same issue, any updates?

nikini commented 7 years ago

No updates yet. Sorry, but I'm busy at work and this is outside my current work. I welcome any pull request and I approve it if it's ok :)

Will be on it this week, hopefully

AmitMY commented 7 years ago

Finally found something beautiful that my team agrees to use, and then this :(

kctang commented 7 years ago

@AmitMY If you need it now, just include the classes directly in your project. I tried it - very little effort and works nicely. You can switch back to depending on this package when this issue is resolved.

Even better if you can help fix it with a pr. It is free & open source after all. :-)

AmitMY commented 7 years ago

@kctang Works! Thanks. If I'll figure the issue out, will definitely make a PR

nikini commented 7 years ago

The thing I want to test is the zoom functionality from the current slides component. If that should work properly, then this isn't needed anymore.

nikini commented 7 years ago

Can you test the new version (0.1.0) and tell me if you still have this issue?