Don't ask questions when --silent flag is enabled; fixes #1066

nim-lang / nimble

Package manager for the Nim programming language.

Other

1.24k stars 174 forks source link

Don't ask questions when --silent flag is enabled; fixes #1066 #1136

Closed xTrayambak closed 9 months ago

xTrayambak commented 10 months ago

Don't ask questions when --silent is set; fixes #1066
Remove accidental files

The bug in question (#1066) states that when --silent is passed over, it works as intended, until it comes to asking a question. In that case, it doesn't print the question, as intended, but still attempts to read the answer. This patch just makes all questions default to true if --silent is set so that no questions need to be asked.

xTrayambak commented 10 months ago

Also, sorry for the first commit that added a ton of garbage. It definitely makes reviewing a nightmare but I forgot to remove nimbledeps/ beforehand. Perhaps that directory should be added to .gitignore?

ringabout commented 10 months ago

Perhaps that directory should be added to .gitignore?

Make sense