search

nim-lang / nimble

Package manager for the Nim programming language.
Other
1.24k stars 174 forks source link

nimble publish when parsing tags, if whitespace strutils.split() puts empty string in packages.json #1204

Closed bloomingchad closed 2 months ago

bloomingchad commented 2 months ago

when you publish using nimble, it asks for tags. if a newbie user is typing the tags,

for example: "tag1 tag2 tag3 tag4 "<<<(this last char before ") the trailing white space at the last will be parsed as a empty string [""] into tags field of packages.json

this will result in a ci error where the package_scanner.nim will return at line 157: logPackageError(displayName & " has empty tags")

wasted ci resources, redundant workflow approvals, wasted time and makes us look buggy.

Araq commented 2 months ago

If only the stdlib had something like splitWhitespace...