search

nim-lang / nimble

Package manager for the Nim programming language.
Other
1.24k stars 174 forks source link

Enables SAT by default to test against the CI #1209

Closed jmgomez closed 1 month ago

xTrayambak commented 2 months ago

Compiling Nimble right now gives this error:

/home/tray/Documents/Projects/nimble/src/nimblepkg/nimblesat.nim(337, 35) Error: attempting to call undeclared routine: 'addUnique'
       Tip: 6 messages have been suppressed, use --verbose to show them.
nimble.nim:229           buildFromDir

    Error:  Build failed for the package: nimble

Is the SAT solver done or are you still working on it? I'd be down to helping out if you need any help :)

jmgomez commented 2 months ago

Compiling Nimble right now gives this error:

/home/tray/Documents/Projects/nimble/src/nimblepkg/nimblesat.nim(337, 35) Error: attempting to call undeclared routine: 'addUnique'
       Tip: 6 messages have been suppressed, use --verbose to show them.
nimble.nim:229           buildFromDir

    Error:  Build failed for the package: nimble

The error is because that function is only in newer std versions. Will take care of it.

Is the SAT solver done or are you still working on it?

Im at the point of making it work with all other Nimble commands and it needs real world testing before making it the default, which probably should be aligned with making local install the default too. The cache also needs more work.

jmgomez commented 2 months ago

Getting closer. Missing one test from tuninstall that only fails in linux and the lock feature