nimbella / aio-cli-plugin-runtime

Nimbella Fork of the Adobe I/O Runtime plugin for Apache OpenWhisk.
https://nimbella.com
Apache License 2.0
2 stars 1 forks source link

Add a toggle for the namespace header suppression #18

Closed joshuaauerbachwatson closed 3 years ago

joshuaauerbachwatson commented 3 years ago

Adds a toggle for the namespace header suppression

Description

Our modification to the upstream version was unconditionally removing the "no namespace" namespace headers from all option sets. I changed this to a toggle which is false by default. When aio is incorporated into nim and will run in a browser (where there are CORS issues related to headers) the toggle can be set to true.

Related Issue

Issue #8

Motivation and Context

It is felt to be unwise to suppress this header unconditionally and directly in aio. This change lowers the exposure of taking this step and allows it to be done only when required.

How Has This Been Tested?

No testing yet. One reason I used a PR against a branch instead of just changing the branch was that I had questions about which tests to run.