search

nimblehq / android-templates

Our optimized Android templates used in our projects
https://nimblehq.co/
MIT License
91 stars 23 forks source link

Replace danger-ruby with danger-kotlin #494

Open luongvo opened 1 year ago

luongvo commented 1 year ago

Why

We're using danger-ruby which requires setting up Ruby env for execution while mainly working with Android/Kotlin env.

https://github.com/nimblehq/android-templates/blob/3f4b9c336422f03ddaa0813cc8de20ec70574637/.github/workflows/review_pull_request.yml#L61-L82

Using danger-kotlin would bring better language integration & workflow optimization.

Who Benefits?

Developers

luongvo commented 3 months ago

@ryan-conway Due to an unresolved issue, move this back to "Ice-box" 🤒