search

nipraxis-fall-2022 / diagnostics-NME

0 stars 4 forks source link

Ready for review #26

Closed jagruti8 closed 2 years ago

jagruti8 commented 2 years ago

Hi, @pxr687 @eilidhmacnicol @matthew-brett @effigies @oesteban - please can you review our project?

jagruti8 commented 2 years ago

Hi, @pxr687 @eilidhmacnicol @matthew-brett @effigies @oesteban - I made some more changes to the code. If it is not yet reviewed its fine, else it would be great if the updated one can be reviewed again. Thanks

oesteban commented 2 years ago

Hi @jagruti8,

I can see 7 open issues by @Nauman702 and @mtach -- what is the expectation for those? The team should gather up and decide whether they can just be closed or merged in.

We will review the main branch as soon as the team can confirm that is what needs to be reviewed.

jagruti8 commented 2 years ago

Hi @oesteban , yeah now the main branch can be reviewed. Thanks

oesteban commented 2 years ago

I'll be reviewing this project over the following days. Whenever I find something that could be addressed, I'll post new issues (e.g., #28)

oesteban commented 2 years ago

Note: I'll notify you when I'm done (and will also nudge the other course instructors)