search

nipraxis-fall-2022 / diagnostics-NME

0 stars 4 forks source link

Missing dependency - scikit-image #29

Open oesteban opened 1 year ago

oesteban commented 1 year ago

After downloading and installing, the execution of:

python scripts/find_outliers.py data

fails unless skimage is installed (thanks to @effigies for spotting this issue).

Please add the dependency to the pyproject.toml.

Then, I would suggest removing the requirements.txt file, as duplicity in responsibilities is a bad idea (cc @matthew-brett @effigies for insights on whether the presence of a requirements.txt file was suggested by us, or if there's something I'm missing).

effigies commented 1 year ago

I believe we had suggested a requirements.txt file. It is definitely simple and allows you to do testing if you manage to break your package, but you're right that there is a synchronization cost.