nish-kishore / sirfunctions

Key functions used by the SIR team
Other
0 stars 0 forks source link

extract_country_data() should not require attaching spatial files #71

Closed mcuadera closed 5 months ago

mcuadera commented 5 months ago

This is just a suggestion.

get_all_polio_data() may or may not include spatial files. If so, we need to make sure that extract_country_data() should still work if get_all_polio_data() does not have spatial files attached to it. We can do a check in the function and see if there are spatial files in raw data first before subsetting the spatial files.

Some of the sirfunctions functions that perform calculations do not require datasets with spatial files to work. This change will increase flexibility of using such functions, especially if the datasets they use are coming from the output of extract_country_data().