nitefood / asn

ASN / RPKI validity / BGP stats / IPv4v6 / Prefix / URL / ASPath / Organization / IP reputation / IP geolocation / IP fingerprinting / Network recon / lookup API server / Web traceroute server
MIT License
1.33k stars 161 forks source link

Feature request: Add asn_lookup hyperlink for "Remaining IPs" and formatting changes #16

Closed ScrumpyJack closed 2 years ago

ScrumpyJack commented 3 years ago

Love the new updates. Great idea having added the ability to just click on a hop for a new asn_lookup.

Can we do the same for the remaining IPs that get "ignored"? To avoid ambiguity, in this screenshot 172.217.1.174

asn

While I love this new feature, it does make the hop output a bit busy. Can we remove the unscores from the hyperlinks and open the links in a new window (style="text-decoration: none;" and target="_blank" or something)? I'm not sure aha supports that out of the box, so maybe a stylesheet?

My OCD is kicking in now, and the links to APIs seem inconsistent. Currently in the detailed ASN lookup top section we have

WHOIS, host.io and ipinfo.io

Can we change that to

whois, host and ipinfo (and without the chain link icon thing)

I don't mind doing this but as it's really esthetics and not functional, do feel free to tell me to naff off and get a life.

ASN number lookup output hurts my brain at the moment, but it's super rich. Not sure how much sense it makes to do traceroutes to subnets, but maybe I'm missing something. I will spend more time playing with it soon.

Thanks again for this great tool

nitefood commented 3 years ago

First things first:

do feel free to tell me to naff off and get a life

I never would, I welcome your (just as anybody's) feedback, and am thankful that someone is investing their precious time to help improve the tool. I always try to make the tool as user-friendly and functional as possible, but I am a network engineer (who is inherently rather inept at web designing :), therefore fresh and unbiased external opinions are something I really appreciate.

Can we do the same for the remaining IPs that get "ignored"? To avoid ambiguity, in this screenshot 172.217.1.174

Sure thing, will add that next. Good idea.

Can we remove the unscores from the hyperlinks and open the links in a new window (style="text-decoration: none;" and target="_blank" or something)?

Good point about the underlines, it didn't feel entirely right to me as well. A good compromise would be to make the underline appear only on hover. I disagree about the target=_blank part though: that's perfect for external links (and it already works like that), but placing it everywhere can become a popup/new tab nightmare real fast. After all, a middle click can work around that so that you get the best of both worlds.

Can we change that to whois, host and ipinfo (and without the chain link icon thing)

I'd like to retain a hyperlink distinction between the whois popup and external links, and the chain link icon was the quickest thing I could come up with without resorting to fontawesome and the likes. Any suggestions on how to distinguish those, and an alternative formatting style (I'm not entirely convinced with the looks either)?

Not sure how much sense it makes to do traceroutes to subnets

Not sure about which part you're referring to, but a traceroute to a subnet (in regard to how asn performs it) is really just a traceroute to the first IP in the subnet, which is consistent with traceroutes to any other IP in the same CIDR block (therefore giving you insight to what the AS path to the target is).

Thanks for your feedback!

nitefood commented 3 years ago

Ah, by the way:

ASN number lookup output hurts my brain at the moment

if you refer to the uneven spacing between the lines, that's due to a known bug in aha v0.5, which was fixed in v0.5.1, but some distros still package the older aha version. If that's the case (and you're using aha v0.5), please try upgrading it, that should fix the issue. I was planning to mention this in the README, but eventually forgot to.

nitefood commented 3 years ago

I've attached a script version with hidden hyperlinks almost everywhere, only showing them on hover. The AS number output and hop list look a lot cleaner now, imho. Also, I've added hyperlinks for the IXP facilities in both trace hops and "peering @" lists.

Please test it when you get a minute, and let me know what you think.

asn.txt

ScrumpyJack commented 3 years ago

Ah, by the way:

ASN number lookup output hurts my brain at the moment

I'm just referring to the sheer amount of information. Granted, I picked google here so there's more than usual, but it does make my brain hurt.

asnb

Just for giggles, try AS2914 (NTT)

ScrumpyJack commented 3 years ago

Could you remove all underline links in the html output? Hidden until hover is so much better.

nitefood commented 3 years ago

Latest commit removes them from the busiest parts of the output. I think it's a good compromise. Now that I think of it, I could just add a server option that enables or disables them globally. I want to leave this issue open until I get a decent enough solution for the remaining formatting (e.g. external links). Any suggestion welcome :-)

ScrumpyJack commented 3 years ago

That looks much better. Thank you.

I want to leave this issue open until I get a decent enough solution for the remaining formatting (e.g. external links).

Do you mean a way to show that the tool is external that would replace the chain link icon?

nitefood commented 3 years ago

Yes, exactly. And maybe some different formatting style that looks a bit less 90's too

nitefood commented 2 years ago

Some time has passed, and we'll stick to the nineties for the time being, I guess. Feel free to reopen if anything comes to mind :-)