search

nitefood / asn

ASN / RPKI validity / BGP stats / IPv4v6 / Prefix / URL / ASPath / Organization / IP reputation / IP geolocation / IP fingerprinting / Network recon / lookup API server / Web traceroute server
MIT License
1.31k stars 159 forks source link

debian-based Dockerfile #52

Closed anarcat closed 8 months ago

anarcat commented 9 months ago

This is similar to #51 but resolves a few issues:

  1. doesn't run as the root user by default (this can be changed at runtime of course)
  2. add missing grepcidr dependency

This is based on Debian because that is what I am most familiar with: even though there seems to be a grepcidr3 package in Alpine, I couldn't figure out how to install it in the build.

Closes: #49

nitefood commented 9 months ago

Thanks for the contributions everyone, haven't had a chance to test this out yet (very busy period), but hopefully will ASAP :-)

nitefood commented 8 months ago

Hey @anarcat,

thanks a lot for your contribution! I've taken a look at both PRs (this and #51) and eventually decided to go the Alpine route since the resulting image is a lot smaller (I managed to install the grepcidr package by basing the container on the Alpine Edge image). Nevertheless I appreciate your feedback and will make sure to acknowledge your contribution in the final release notes/README.

Thanks!

anarcat commented 8 months ago

hey no problem! :)

though not to micromanage or anything, but #51 is still open, and the comments i made there haven't been adressed. :)

nitefood commented 8 months ago

Yeah I did address those in a PR against @33Fraise33's code here. Perhaps not the best way, I'm not a daily git user :-) I will eventually commit directly to #51 if there are no feedbacks. Feel free to comment with any feedback you may have. Thanks again!

anarcat commented 8 months ago

If I was you, i would just merge the other MR and patch on top, or write something new from scratch. It's kind of odd to see a MR against a fork, but i guess that might make sense too!