search

nitobuendia / oura-custom-component

Oura Custom Component for Home-Assistant. Adds Oura Ring sleep information.
108 stars 25 forks source link

Request: Add to HACS #1

Closed JamieP83 closed 3 years ago

JamieP83 commented 4 years ago

Hey, would be great to have this available via HACS https://hacs.xyz/

tuomaskuittinen commented 4 years ago

+1 for this!

adrkable commented 4 years ago

+1

nitobuendia commented 4 years ago

Happy to see that this is helpful. I will have a look at the documentation for HACS for Custom Components and see how involved it is to add the support.

nitobuendia commented 4 years ago

I think all requirements are now ready. The only missing requirement is to transfer it to HACS custom-components or hacs default as per this guide.

I have sent the pull request to add to default.

I am unclear whether repository also needs to be transferred to the custom-components. However, I do not have permissions to do so.

nitobuendia commented 4 years ago

Added to wheels-custom-integrations (PR#65).

nitobuendia commented 4 years ago

Created PR for Brand logos.

nitobuendia commented 4 years ago

Wheels was not needed since there were no requirements. Indeed, the only requirement is requests which is already existing in Home-Assistant.

nitobuendia commented 4 years ago

The request to add to HACS seems approved.

@JamieP83 @tuomaskuittinen @adrkable If you could verify that you can see it on HACS in a few hours or days, I would appreciate it :) (Not sure what the normal ETA is).

tuomaskuittinen commented 4 years ago

@nitobuendia I was able to find and install this with HACS, thanks! I had installed this previously manually and now removed the custom_components/oura folder and installed with HACS. My "oura-token" file was left untouch and worked with HACS version like it worked before with manual installation, as expected.

However I run into problem that my "Configuration validation" did not finish and when running "core check" from the command line there was an error about "core integration not found". I did not try to restart my Home Assistant with error in the configs.

I was able to resolve this by removing "core" from manifest.json dependencies list and everything seems to work now.

nitobuendia commented 4 years ago

Thanks a lot for testing and installing, @tuomaskuittinen

nitobuendia commented 4 years ago

HACS support will be reverted until YAML (or equivalent non-UI configuration) becomes a supported mode for integrations (reference).

nitobuendia commented 4 years ago

For those who are affected by the HACS decision, sharing my personal views on the YAML issue.

nitobuendia commented 3 years ago

Hi @JamieP83, everyone,

I will be closing this for now. I do not think there are short-term plans to include in HACS; and with issues like the ones reported here and here, I think that if you install a Custom Component, you should make a bit of due diligence on the code you add to the system first :)

leikoilja commented 1 year ago

@nitobuendia, do you think it's time to put aside the personal stride regarding YAML file configuration option and include the integration in HACS? :)