search

nmusolino / codeowners

Tool for identifying the owners of files under Github's CODEOWNERS feature.
GNU General Public License v3.0
2 stars 1 forks source link

Improve test robustness on MacOS #4

Closed shaleh closed 4 years ago

shaleh commented 4 years ago

The functions to create temporary paths on MacOS return paths which are not resolved, full paths and instead could be behind links. To work around this, always 'resolve()' paths.

shaleh commented 4 years ago

I wasn't certain either. Not returning a resolved path allows a test to verify that links are handled. But it does push a burden on all tests.

nmusolino commented 4 years ago

I wasn't certain either. Not returning a resolved path allows a test to verify that links are handled. But it does push a burden on all tests.

That’s a good point.

I’ll merge this PR as-is. Perhaps, in the future, I can add tests that specifically exercise symlink handling.