nnstreamer / nnstreamer

:twisted_rightwards_arrows: Neural Network (NN) Streamer, Stream Processing Paradigm for Neural Network Apps/Devices.
https://nnstreamer.ai
GNU Lesser General Public License v2.1
683 stars 171 forks source link

build: update header path #4449

Closed dkson95 closed 1 month ago

dkson95 commented 1 month ago

Fix fatal error: asm-arm/hwcap.h: No such file or directory


[Template] PR Description

In general, github system automatically copies your commit message for your convenience. Please remove unused part of the template after writing your own PR description with this template.

$ git commit -s filename1 filename2 ... [enter]

Summarize changes in around 50 characters or less

More detailed explanatory text, if necessary. Wrap it to about 72
characters or so. In some contexts, the first line is treated as the
subject of the commit and the rest of the text as the body. The
blank line separating the summary from the body is critical;
various tools like `log`, `shortlog` and `rebase` can get confused 
if you run the two together.

Further paragraphs come after blank lines.

**Changes proposed in this PR:**
- Bullet points are okay, too
- Typically a hyphen or asterisk is used for the bullet, preceded
  by a single space, with blank lines in between, but conventions vary here.

Resolves: #123
See also: #456, #789

**Self evaluation:**
1. Build test: [ ]Passed [ ]Failed [*]Skipped
2. Run test: [ ]Passed [ ]Failed [*]Skipped

**How to evaluate:**
1. Describe how to evaluate in order to be reproduced by reviewer(s).

Add signed-off message automatically by running **$git commit -s ...** command.

$ git push origin <your_branch_name>
myungjoo commented 1 month ago

If this is for Tizen 9.0, please add version-based #if (we often need backporting...)

dkson95 commented 1 month ago

@dkson95 Is this change effective since Tizen 9.0? or all Tizen?

Okay, I've checked and this change is fine since Tizen 6.0.

If this is for Tizen 9.0, please add version-based #if (we often need backporting...)

Actually this is for Tizen next ver, but compatible with prev. So, version-based #if might not be required on this case ?

myungjoo commented 1 month ago

@dkson95 Is this change effective since Tizen 9.0? or all Tizen?

Okay, I've checked and this change is fine since Tizen 6.0.

If this is for Tizen 9.0, please add version-based #if (we often need backporting...)

Actually this is for Tizen next ver, but compatible with prev. So, version-based #if might not be required on this case ?

Then, it's ok to proceed. Thanks!