Closed dschach closed 1 year ago
@dschach apologies, it's been a crazy couple of months for me. will try to take a look at these soon.
I promise I'll get to this soon...
@dschach just checking in, there's a couple of pending changes here but happy to make them if you're busy lately.
Yeah, I'm swamped right now, but I will make time to update the PR and to see what I can get done.
@dschach Absolutely no rush. As you know from working with me on this repo in the past I have a lot going on as well and am not checking in here as regularly as I'd like to be.
Changees made. Ready for review.
@no-stack-dub-sack Bump on this PR - I'd like to start looking into tslint->eslint and to making a command line interface, once this is merged from my fork. Thanks!
Hey, sorry, I've been totally swamped lately. Will take a look in the next couple days.
@dschach The PR looks mostly good at this point, thanks for addressing the review comments. Any idea what's up with the yarn.lock file, though? I only see one dependency change (the addition of husky), so would expect a much smaller diff here. Relatedly, I think you can maybe just back out the husky changes now, right? If I remember correctly, highlight JS was previously being updated using husky via the precommit hook, but since you changed it to a manual update process, I think husky is no longer needed, or am I missing maybe something?
Also, I'm assuming you've tested this and everything looks good on your end? If so, since there's no change to core documentation generation code here, I won't feel the need to test this myself assuming you've done so. Thanks and let me know! If we can come to a conclusion on the husky stuff I can get this merged and released within the week.
I've tested it with these versions on a few of my repos by overriding the library you've bundled. It works well, as far as I can see. Check any of my repos and they're done with 11.7.
Husky won't do anything yet, but we can install it now and it won't run anything if it doesn't have anything in its hooks.
So yeah, it's tested :)
@dschach Thanks - I think my preference at this point would be to remove husky (and the changes to the lock file) until we need it for something. When we do, it can be installed and go in as a part of that pull request.
Removed. PR is only to update highlight and the new index.js file
@dschach reverted lockfile changes and removed the prepare
script from package.json
Will get this released soon. Would like to give it a few days to see if #68 materializes and if they can go out as part of the same release if so.