search

noaa-iea / fk-esr-info

Florida Keys infographic update using Ecosystem Status Report website
http://noaa-iea.github.io/fk-esr-info
MIT License
0 stars 0 forks source link

pretty caption and source #8

Open bbest opened 3 years ago

bbest commented 3 years ago

For now looks pretty plain, eg https://marinebon.org/fk-esr-info/modals/DIN.html:

NA Source: NOAA Atlantic Oceanographic and Meteorological Laboratory’s South Florida Project, Ocean Chemistry and Ecosystems Division.

So what to do with NA caption in icons to data | fk-esr-info - Google Sheets?

A few approaches possible:

  1. Leave blank "" vs "NA".
  2. Swap out caption with title using caption <- ifelse(is.na(caption), title, caption) in the _make_infographic_modals.R using the _infographic_modal_template.html
  3. Update title in icons to data | fk-esr-info - Google Sheets and run by Kelly
mspector13 commented 3 years ago

Inserted caption <- ifelse(is.na(caption), title, caption) in line 47 of _make_infographic_modals.R

Will talk to Kelly about writing our own captions on 3/3. Hope I didn't break anything!

bbest commented 3 years ago

Great @mspector13, we just updated modals with this fix in commit https://github.com/marinebon/fk-esr-info/commit/79f9ea2795793b711092a9d9efecc8a7bb67d5de by running _make_infographic_modals.R.

We might need a period between caption and source, plus other formatting like icons mentioned by Jenn in Generic Modal Window Layout - Google Slides.

The other main task for Kelly to update Caption in icons to data | fk-esr-info - Google Sheets.