search

noaignite / create-ignite-app

Boilerplate for React with Next.js and MUI
17 stars 2 forks source link

Feature/metadata #2

Closed Npahlfer closed 4 years ago

Npahlfer commented 4 years ago

Adds MetaData container.

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/oakwood/create-oakwood-app/ov0d9pzwg
✅ Preview: https://create-oakwood-app-git-feature-metadata.oakwood.vercel.app

maeertin commented 4 years ago

Would be nice to go through the tags used and make sure we're up to date with standards.

Npahlfer commented 4 years ago

@maeertin I removed the itemProp tags and added some:

maeertin commented 4 years ago

Hey @vincentboiardt, what do think about this PR? Is the Meta component set up correctly? Should we look into merging it?

One issue that I have is that I can't see any og:title printed even though this <Meta title="Home | Create Oakwood App" /> is being used on the home route.

vincentboiardt commented 4 years ago

The Accelerator has a bunch of SEO related components (https://github.com/oakwood/accelerator/tree/master/packages/accelerator/src/components) including MetaData (https://github.com/oakwood/accelerator/blob/master/packages/accelerator/src/components/MetaData/index.js)

I think they can stay there instead of in COA.