search

noaignite / create-ignite-app

Boilerplate for React with Next.js and MUI
17 stars 2 forks source link

AppFooter rendering ul without li #39

Closed alexanderflink closed 2 years ago

alexanderflink commented 2 years ago

https://github.com/noaignite/create-ignite-app/blob/dc2e7eb00f9ea854674bfddac3ddbb051d624fda/src/containers/App/partials/AppFooter.js#L50

Noticed that AppFooter renders an <ul> with only <a> elements in it. The links should probably be wrapped in <li> elements.

maeertin commented 2 years ago

Thanks @alexanderflink, I simplified the markup for the links and it's now correct :)